build: nudge devs about Redwood release in github #34807
Conversation
|
Thanks for the pull request, @cmltaWt0! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
the
open-source-contribution
|
@kdmccormick please review. |
cmltaWt0
force-pushed
the
max/update-pr-template-redwood
branch
from
e71c5a9 to
a53461d
Compare
There was a problem hiding this comment.
A couple suggestions, all optional.
@cmltaWt0 In general, I sense that most developers just skim past these release nudges. My experience is that PR templates get ignored if they are more than just a few sentences. When it comes to which changes should be backported to which release, maybe a wiki page would be best? That way, we could link it here in the template, and then just update the wiki page from release to release.
.github/pull_request_template.md
Outdated
| 🌳🌳🌳🌳 or ask in the #wg-build-test-release Slack channel if you have any questions or need help. | ||
| 🌳🌳 | ||
|
|
||
| 🌳🌳🌳🌳🌳🌳 🌳 Note: the Quince release is still supported. |
There was a problem hiding this comment.
| 🌳🌳🌳🌳🌳🌳 🌳 Note: the Quince release is still supported. | |
| 🌳🌳🌳🌳🌳🌳 🌳 Note: the Quince release will also be supported until 2024-06-10. |
suggestion - more specifics
.github/pull_request_template.md
Outdated
| 🌳🌳🌳🌳 or ask in the #wg-build-test-release Slack channel if you have any questions or need help. | ||
| 🌳🌳 | ||
|
|
||
| 🌳🌳🌳🌳🌳🌳 🌳 Note: the Quince release is still supported. | ||
| Please consider whether your change should be applied to Palm as well. |
There was a problem hiding this comment.
What sort of changes should be backported to Palm? Just critical bug fixes? Without more information, some developers might not be sure what to do here.
There was a problem hiding this comment.
Thanks! It's a typo! No reason to do it for devs.
Will fix.
.github/pull_request_template.md
Outdated
| @@ -1,11 +1,13 @@ | |||
| <!-- | |||
|
|
|||
| 🌳🌳 | |||
There was a problem hiding this comment.
Do you want to change these to 🌲 for Redwood? The change might catch some devs' attention.
There was a problem hiding this comment.
I looked at this icon but it doesn't look like a redwood tree :)
But to get some attention I totally agree. Will update.
Good point. I'm aware of this nudge, so I typically read... |
Add link to the Support Development Guidelines regarding the currently supported releases.
cmltaWt0
force-pushed
the
max/update-pr-template-redwood
branch
from
a53461d to
d88732f
Compare
|
@kdmccormick I've updated the nudge text and created a wiki page. |
|
@cmltaWt0 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Remind devs about backporting their bug fixes to
the Redwood master branch and think about
backporting to Quince as well