Upgrade pymongo #34642
Closed
Upgrade pymongo #34642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awais786
force-pushed
the
upgrade-pymongo-
branch
2 times, most recently
from
31da7e8 to
12e4b24
Compare
awais786
commented
Apr 28, 2024
| @@ -676,7 +676,8 @@ def _send_course_email(entry_id, email_id, to_list, global_email_context, subtas | |||
| return subtask_status, None | |||
| finally: | |||
| # Clean up at the end. | |||
| connection.close() | |||
| pass | |||
There was a problem hiding this comment.
awais786
commented
Apr 29, 2024
xmodule/contentstore/mongo.py
Outdated
| @@ -142,12 +143,16 @@ def find(self, location, throw_on_not_found=True, as_stream=False): # lint-amne | |||
| 'thumbnail', | |||
| thumbnail_location[4] | |||
| ) | |||
|
|
|||
| if getattr(fp, 'md5', None) is None: | |||
There was a problem hiding this comment.
awais786
force-pushed
the
upgrade-pymongo-
branch
from
d16b90e to
21157da
Compare
feat!: upgrading pymongo to 4.0 fix: Update Makefile feat!: Remove md5 checksums from gridfs and remove disable. feat!: Remove md5 checksums from gridfs and remove disable. feat!: Remove md5 checksums from gridfs and remove disable. feat!: Remove md5 checksums from gridfs and remove disable. feat!: Remove md5 checksums from gridfs and remove disable. feat!: Remove md5 checksums from gridfs and remove disable. feat: Upgrade Python dependency enmerkar-underscore Update to a Python 3.11 compatible version Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master` feat: Upgrade Python dependency edx-codejail Update to a Python 3.11 compatible version Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master` Revert "build: Python requirements upgrade and lxml build without binary (openedx#34…" (openedx#34661) This reverts commit 52adce4 because we were getting this in the build pipeline: ``` WARNING: lxml 5.2.1 does not provide the extra 'html-clean' ERROR: Exception: Traceback (most recent call last): File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/pip/_internal/cli/base_command.py", line 173, in _main status = self.run(options, args) File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/pip/_internal/cli/req_command.py", line 203, in wrapper return func(self, options, args) File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/pip/_internal/commands/install.py", line 315, in run requirement_set = resolver.resolve( File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/pip/_internal/resolution/resolvelib/resolver.py", line 94, in resolve result = self._result = resolver.resolve( File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/pip/_vendor/resolvelib/resolvers.py", line 472, in resolve state = resolution.resolve(requirements, max_rounds=max_rounds) File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/pip/_vendor/resolvelib/resolvers.py", line 366, in resolve failure_causes = self._attempt_to_pin_criterion(name) File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/pip/_vendor/resolvelib/resolvers.py", line 221, in _attempt_to_pin_criterion satisfied = all( File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/pip/_vendor/resolvelib/resolvers.py", line 222, in <genexpr> self._p.is_satisfied_by(requirement=r, candidate=candidate) File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/pip/_internal/resolution/resolvelib/provider.py", line 178, in is_satisfied_by return requirement.is_satisfied_by(candidate) File "/edx/app/edxapp/venvs/edxapp/lib/python3.8/site-packages/pip/_internal/resolution/resolvelib/requirements.py", line 84, in is_satisfied_by assert candidate.name == self.name, ( AssertionError: Internal issue: Candidate is not for this requirement lxml[html-clean,html-clean] vs lxml[html-clean] WARNING: You are using pip version 21.2.1; however, version 24.0 is available. You should consider upgrading via the '/edx/app/edxapp/venvs/edxapp/bin/python -m pip install --upgrade pip' command. ```
awais786
force-pushed
the
upgrade-pymongo-
branch
from
63ed354 to
bca5886
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version contains multiple breaking changes.
1: One of main is close connection. It happens at multiple places in code base and need some in depth domain knowledge about when reopen.
2: database file has removed call method and its in use in MongoDBProxy. I just added a temporary fix to run tests.
openedx/MongoDBProxy#22
3: md5 checksum removed. I added temp fix to run the test suite. mongodb/mongo-python-driver@e271315