Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade to node 18 #34311

Merged
merged 3 commits into from
Apr 9, 2024
Merged

chore: upgrade to node 18 #34311

merged 3 commits into from
Apr 9, 2024

Conversation

brian-smith-tcril
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril commented Feb 28, 2024 •
edited
Loading

@brian-smith-tcril brian-smith-tcril force-pushed the node-18 branch 30 times, most recently from 72e6acf to cb1e838 Compare February 29, 2024 13:23
@brian-smith-tcril brian-smith-tcril force-pushed the node-18 branch 5 times, most recently from f5b6304 to 3b06815 Compare March 27, 2024 18:17
@brian-smith-tcril brian-smith-tcril marked this pull request as ready for review March 27, 2024 18:55
@feanil feanil requested a review from arbrandes March 29, 2024 18:56
@brian-smith-tcril brian-smith-tcril mentioned this pull request Mar 29, 2024
Closed
arbrandes
arbrandes approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections, and thanks a bunch for finding fixes for all those failures!

@abdullahwaheed
Copy link
Contributor

i have tried running JS tests in edx-platform shell and got following error. could you please verify it since JS tests aren't running in the Ci as well

image

@brian-smith-tcril
Copy link
Contributor Author

since JS tests aren't running in the Ci as well

What do you mean they aren't running in the CI? The status check for JS isn't passing because it expects node 16, but the tests are running and passing.

@abdullahwaheed
Copy link
Contributor

since JS tests aren't running in the Ci as well

What do you mean they aren't running in the CI? The status check for JS isn't passing because it expects node 16, but the tests are running and passing.

yes i meant its CI wasn't running. Are these tests running locally for you?

@brian-smith-tcril
Copy link
Contributor Author

brian-smith-tcril commented Apr 4, 2024 •
edited
Loading

yes i meant its CI wasn't running.

@abdullahwaheed

image

https://github.com/openedx/edx-platform/actions/runs/8543854254/job/23408570854?pr=34311

@brian-smith-tcril brian-smith-tcril force-pushed the node-18 branch 2 times, most recently from 39e05ed to 2fb727f Compare April 8, 2024 15:15
@feanil feanil merged commit 1e9f36c into openedx:master Apr 9, 2024
67 checks passed
@feanil feanil mentioned this pull request Apr 9, 2024
Merged
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been rolled back from the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbrandes arbrandes arbrandes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brian-smith-tcril @abdullahwaheed @edx-pipeline-bot @arbrandes @feanil