-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade xblock-utils to 3.2.0 to support TinyMCE v5 #34149
chore: upgrade xblock-utils to 3.2.0 to support TinyMCE v5 #34149
Conversation
Thanks for the pull request, @Anas12091101! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Hi there, @Anas12091101; since there will not be another Palm release according to the Open edX release schedule, I'll close this PR in the name of BTR. You can open a backport PR to the Quince branch to include these changes in the next release if you haven't already or wait until Redwood. Thanks! |
@mariajgrimaldi, this issue is only present in the Palm release. When |
@Anas12091101: I understand. Now, I closed this issue because, according to the Open edX release schedule, there will not be another Palm release. So, I'll take this conversation to the BTR Slack channel to hear what other folks think. |
@mariajgrimaldi any updates on this? |
Here's the thread I opened: https://openedx.slack.com/archives/C049JQZFR5E/p1710851198308489. So, we won't have a new palm release but you folks could use palm.master in your deployments. I'll try finding someone to review/merge this, thanks! |
thanks |
Hi @Anas12091101 and @mariajgrimaldi, I was doing some tests and it seems to me that this change works perfectly, also taking advantage of this improvement, we took the liberty to upload this change to the sandbox (palm version) so you can corroborate that it works perfectly if you want :) |
5f9a30e
into
openedx:open-release/palm.master
@Anas12091101 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR upgrades xblock-utils to version 3.2.0 to support TinyMCE v5 in the Palm release. The current version of xblock-utils is 3.0.0, configured for TinyMCE v4. This configuration causes an error after the upgrading of TinyMCE from v4.0.20 to v5.5.1 in this PR: #30335
Useful information to include:
Before:
Supporting information
Issue: mitodl/edx-sga#346
Discussion: https://discuss.openedx.org/t/tinymce-problem-in-edx-sga-problems-modern-theme-not-found/11148
xblock-util v3.2.0 TinyMCE changes PR: openedx-unsupported/xblock-utils#207
Testing instructions
Edit
and scroll down to theSolution
setting.WYSIWYG
editor is functioning properly.Deadline
None