Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added correct image for FB sharing (palm.master) #33783

Conversation

vladislavkeblysh
Copy link

@vladislavkeblysh vladislavkeblysh commented Nov 23, 2023

Issue

This pull request addresses the issue related to missing Open Graph (OG) image metadata in the HTML.

Context

The absence of the <meta property="og:image" /> tag was causing issues with social media sharing and previewing content. This addition ensures that the correct OG image is associated with the page for improved sharing capabilities.

Related Pull Requests

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 23, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 23, 2023

Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@vladislavkeblysh vladislavkeblysh marked this pull request as draft November 23, 2023 10:39
@vladislavkeblysh vladislavkeblysh changed the title feat: Added correct image for FB sharing feat: Added correct image for FB sharing (palm.master) Nov 23, 2023
@vladislavkeblysh vladislavkeblysh marked this pull request as ready for review November 23, 2023 10:48
@vladislavkeblysh vladislavkeblysh marked this pull request as draft November 23, 2023 10:48
@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Nov 27, 2023
@mariajgrimaldi
Copy link
Member

Hi there, @vladislavkeblysh; since there will not be another Palm release according to the Open edX release schedule, I'll close this PR in the name of BTR. You can open a backport PR to the Quince branch to include these changes in the next release if you haven't already or wait until Redwood after your master PR is merged. Thanks!

@openedx-webhooks
Copy link

@vladislavkeblysh Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants