-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add url that exposes taxonomy tags CRUD API #33525
feat: Add url that exposes taxonomy tags CRUD API #33525
Conversation
Thanks for the pull request, @yusuf-musleh! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@bradenmacdonald @pomegranited I found an issue while testing. When I try to view Taxonomy Tags that have multiple level, the serializer in the openedx-learning fails because the reverse cannot find I'll look more into it, but I assume there is a way to have the URL name spaces carry over for installed django apps? |
@yusuf-musleh I'm not sure exactly what the issue is but it's definitely fixable. You may need to tweak something about how we import the URLs into cms. See here and here. Though from reading those docs it sounds like the namespace should already be automatically set up correctly, so I'm not sure exactly what the issue is. Maybe try adding an explicit namespace like this ? |
1ac511c
to
423faa1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Works well, thank you for working out the issue here @yusuf-musleh !
- I tested this on my devstack with feat: CRUD API for Taxonomy Tags [FC-0036] openedx-learning#96, using the exposed REST API.
- I read through the code
-
I checked for accessibility issuesN/A -
Includes documentationN/A - Commit structure follows OEP-0051
3c1d674
to
972b3b7
Compare
e7d686f
to
9add990
Compare
Include `content_tagging` namespace for content_tagging urls in cms for `sub_tags_link` to work in multi-level taxonomy tags.
9add990
to
4194b65
Compare
@yusuf-musleh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
This PR exposes the CRUD API for Taxonomy Tags implemented in
Supporting information
Related tickets:
Testing instructions
Private-ref: FAL-3519