Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quince backport] Squash Tagging/Taxonomy migrations, bump openedx-learning to 0.2.3 [FC-0030] #33476

Merged

Conversation

bradenmacdonald
Copy link
Contributor

Backport to quince.master

Description

Quince will include the new openedx-learning and openedx-tagging applications. These won't be used much in Quince, but they're included, as the current master version of Open edX is seeing active development of new features using these apps.

The openedx-tagging app went through a number of development iterations and has some somewhat messy migrations, which we recently cleaned up by squashing and simplifying them. This PR pulls in the squashed migrations, both in the openedx-tagging repo and in this edx-platform repo (content_tagging app). If everyone that runs Quince only ever uses the squashed migrations, it will make our lives much easier in the future.

Supporting information

This is a backport of #33438, which we tried to get in for Quince but we missed the initial cutoff by a few hours.

Testing instructions

No manual testing is necessary, just make sure the migrations get applied and the tests pass. There is no user-facing UI for this application yet.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 11, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mtyaka
Copy link
Contributor

mtyaka commented Oct 24, 2023

Thanks for backporting this to Quince @bradenmacdonald! 👍

  • I tested this: I verified that the tests pass and that the changes are identical to the code that was merged into master and is already in production.
  • I read through the code

@mtyaka mtyaka merged commit e41f6b1 into openedx:open-release/quince.master Oct 24, 2023
44 checks passed
@mtyaka mtyaka deleted the tagging-squash-backport branch October 24, 2023 06:33
@openedx-webhooks
Copy link

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@bradenmacdonald
Copy link
Contributor Author

Thanks @mtyaka !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants