fix: downgrade karma-spec-reporter to fix JS test logging #35954
Conversation
kdmccormick
changed the title
There was a problem hiding this comment.
To prevent this from happening in the future, we should add it to ignoreDeps here: https://github.com/openedx/edx-platform/blob/master/.github/renovate.json5#L35 along with a link to fix the issue by upgrading the underlying Karma version.
kdmccormick
force-pushed
the
kdmccormick/karma-spec-runner
branch
from
f4413cb to
bf4740d
Compare
|
@feanil Thanks, I added to |
|
Sounds good. |
The karma-spec-reporter npm package is a Karma plugin which tells Karma to
print the name of each spec (e.g. test case). This is extremely useful
as a maintainer to be able to visually inspect the CI logs and confirm
that we are actually running JS tests and not just giving
false-positives.
We are stuck on an ancient Karma version (0.13.22, lastest is 6.x),
which seems to be incompatible with the latest karma-spec-reporter version
(0.0.36). Since upgrading karma-spec-reporter, spec name printing has
failed with:
02 12 2024 20:59:28.164:WARN [plugin]: Error during loading "karma-spec-reporter" plugin:
Cannot read properties of undefined (reading 'LOG_PRIORITIES')
Downgrading to [email protected] eliminates this error and
restoring spec name printing to our JS CI logs.
kdmccormick
force-pushed
the
kdmccormick/karma-spec-runner
branch
from
bf4740d to
389c4a8
Compare
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
The karma-spec-reporter npm package is a Karma plugin which tells Karma to
print the name of each spec (e.g. test case). This is extremely useful
as a maintainer to be able to visually inspect the CI logs and confirm
that we are actually running JS tests and not just giving
false-positives.
We are stuck on an ancient Karma version (0.13.22, lastest is 6.x),
which seems to be incompatible with the latest karma-spec-reporter version
(0.0.36). Since upgrading karma-spec-reporter, spec name printing has
failed with:
02 12 2024 20:59:28.164:WARN [plugin]: Error during loading "karma-spec-reporter" plugin:
Cannot read properties of undefined (reading 'LOG_PRIORITIES')
Downgrading to [email protected] eliminates this error and
restoring spec name printing to our JS CI logs.
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been rolled back from the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been rolled back from the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
The karma-spec-reporter npm package is a Karma plugin which tells Karma to print the name of each spec (e.g. test case). This is extremely useful as a maintainer to be able to visually inspect the CI logs and confirm that we are actually running JS tests and not just giving false-positives.
We are stuck on an ancient Karma version (0.13.22, lastest is 6.x), which seems to be incompatible with the latest karma-spec-reporter version (0.0.36). Since upgrading karma-spec-reporter, spec name printing has failed with:
Downgrading to [email protected] eliminates this error and restoring spec name printing to our JS CI logs.
Context
This is one of the several existing CI issues we have encountered while removing paver from edx-platform CI.
Testing
Just compare the logs of "Javascript tests / JS / Run JS Tests" CI step with those on master.
this pr
master
Merge Considerations
Open Q for reviewers: How do we prevent renovate from repeating the same upgrade in the future?