Skip to content

Commit

Permalink
fix: downgrade karma-spec-reporter to fix JS test logging (#35954)
Browse files Browse the repository at this point in the history
The karma-spec-reporter npm package is a Karma plugin which tells Karma to
print the name of each spec (e.g. test case). This is extremely useful
as a maintainer to be able to visually inspect the CI logs and confirm
that we are actually running JS tests and not just giving
false-positives.

We are stuck on an ancient Karma version (0.13.22, lastest is 6.x),
which seems to be incompatible with the latest karma-spec-reporter version
(0.0.36). Since upgrading karma-spec-reporter, spec name printing has
failed with:

    02 12 2024 20:59:28.164:WARN [plugin]: Error during loading "karma-spec-reporter" plugin:
      Cannot read properties of undefined (reading 'LOG_PRIORITIES')

Downgrading to [email protected] eliminates this error and
restoring spec name printing to our JS CI logs.
  • Loading branch information
kdmccormick authored and irtazaakram committed Dec 5, 2024
1 parent f19f35b commit 2a7287b
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 8 deletions.
6 changes: 5 additions & 1 deletion .github/renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,11 @@
// When adding an ignoreDep, please include a reason and a public link that we can use to follow up and ensure
// that the ignoreDep is removed.
// This can be done as a comment within the ignoreDeps list.
"ignoreDeps": [],
"ignoreDeps": [
// karma-spec-reporter>0.20.0 does not seem compatible with our super-old 2016 Karma version (0.13.22).
// Ticket link: None, as upgrading Karma does not strike as worth the benefit.
"karma-spec-reporter"
],
"timezone": "America/New_York",
"prConcurrentLimit": 3,
"enabledManagers": ["npm"]
Expand Down
20 changes: 14 additions & 6 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
"karma-requirejs": "1.1.0",
"karma-selenium-webdriver-launcher": "github:openedx/karma-selenium-webdriver-launcher#0.0.4-openedx.0",
"karma-sourcemap-loader": "0.4.0",
"karma-spec-reporter": "0.0.36",
"karma-spec-reporter": "0.0.20",
"karma-webpack": "^5.0.1",
"plato": "1.7.0",
"react-test-renderer": "16.14.0",
Expand Down

0 comments on commit 2a7287b

Please sign in to comment.