Skip to content

Commit

Permalink
build: npm run compile-sass
Browse files Browse the repository at this point in the history
TODO update ADR
TODO themes env var
TODO make compile-requirements
TODO testing
TODO comment in compile_sass.py a la "this could be a shell script"

TODO add details from PR description

Part of: TODO
  • Loading branch information
kdmccormick committed Jul 11, 2023
1 parent 83795ed commit 883d71f
Show file tree
Hide file tree
Showing 6 changed files with 366 additions and 5 deletions.
6 changes: 5 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,12 @@
"version": "0.1.0",
"repository": "https://github.com/openedx/edx-platform",
"scripts": {
"build": "npm run webpack && npm run compile-sass",
"build-dev": "npm run webpack-dev && npm run compile-sass-dev",
"webpack": "NODE_ENV=production webpack --progress --config=${WEBPACK_CONFIG_PATH:-webpack.prod.config.js}",
"webpack-dev": "NODE_ENV=development webpack --progress --config=${WEBPACK_CONFIG_PATH:-webpack.dev.config.js}"
"webpack-dev": "NODE_ENV=development webpack --progress --config=${WEBPACK_CONFIG_PATH:-webpack.dev.config.js}",
"compile-sass": "compile_sass.py",
"compile-sass-dev": "NODE_ENV=development compile_sass.py"
},
"dependencies": {
"@babel/core": "7.19.0",
Expand Down
6 changes: 6 additions & 0 deletions requirements/constraints.txt
Original file line number Diff line number Diff line change
Expand Up @@ -109,3 +109,9 @@ drf-yasg<1.21.6

# Adding pin to avoid any major upgrade
djangorestframework<3.15.0

# Our legacy Sass code is incompatible with anything except this ancient libsass version.
# Here is a ticket to upgrade, but it's of debatable importance given that we are rapidly moving
# away from legacy LMS/CMS frontends:
# https://github.com/openedx/edx-platform/issues/31616
libsass==0.10.0
1 change: 0 additions & 1 deletion requirements/edx/paver.in
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@

edx-opaque-keys # Create and introspect course and xblock identities
lazy # Lazily-evaluated attributes for Python objects
libsass==0.10.0 # Python bindings for the LibSass CSS compiler
markupsafe # XML/HTML/XHTML Markup safe strings
mock # Stub out code with mock objects and make assertions about how they have been used
path # Easier manipulation of filesystem paths
Expand Down
3 changes: 0 additions & 3 deletions requirements/edx/paver.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ idna==3.4
# via requests
lazy==1.5
# via -r requirements/edx/paver.in
libsass==0.10.0
# via -r requirements/edx/paver.in
markupsafe==2.1.3
# via -r requirements/edx/paver.in
mock==5.0.2
Expand All @@ -41,7 +39,6 @@ requests==2.31.0
# via -r requirements/edx/paver.in
six==1.16.0
# via
# libsass
# paver
# python-memcached
stevedore==5.1.0
Expand Down
4 changes: 4 additions & 0 deletions requirements/edx/sass.in
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
-c constraints.txt

click
libsass
Loading

0 comments on commit 883d71f

Please sign in to comment.