Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: setup.py update using script #330

Merged
merged 1 commit into from
Sep 4, 2024
Merged

fix: setup.py update using script #330

merged 1 commit into from
Sep 4, 2024

Conversation

edx-requirements-bot
Copy link
Contributor

Updated repo with setup.py changes for package extras, for more context please have a look into this issue

felipemontoya
felipemontoya approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and it works as it should, install went through without any errors. The changes look exactly like the cookiecutter repo suggests.

@felipemontoya felipemontoya merged commit 8abc612 into master Sep 4, 2024
7 checks passed
@felipemontoya felipemontoya deleted the jenkins/zshkoor/setup-py-updated-9002887 branch September 4, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipemontoya felipemontoya felipemontoya approved these changes

@zubairshakoorarbisoft zubairshakoorarbisoft Awaiting requested review from zubairshakoorarbisoft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edx-requirements-bot @felipemontoya