-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ora filter for submission step rendering #2204
feat: add ora filter for submission step rendering #2204
Conversation
Thanks for the pull request, @BryanttV! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
8a2b120
to
f2fdee2
Compare
Hi @pomegranited, this PR is part of the implementation of the ADR for lightweight extension points, could you take a look at it? Thanks! |
0181c8b
to
3f8408a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Although we're missing some tests, could we add some? Thanks!
3f8408a
to
6ba12da
Compare
Hi @mariajgrimaldi, thanks for the review! I added some tests: f4156f2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Works great, thank you @BryanttV !
Could you merge latest master
to get test passing again, and I'll merge :)
- I tested this using the PR description, both with and without the added filters to ensure no errors.
- I read through the code
- I checked for accessibility issues by navigating with my keyboard.
- Includes documentation
-
User-facing strings are extracted for translationN/A
5ca3093
to
345869a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2204 +/- ##
=======================================
Coverage 95.04% 95.05%
=======================================
Files 191 191
Lines 21045 21083 +38
Branches 1902 1903 +1
=======================================
+ Hits 20002 20040 +38
Misses 779 779
Partials 264 264
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
345869a
to
8ced069
Compare
@BryanttV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR triggers the ORA submission view filter. This filter changes the default template by a custom template with a warning message notifying the student that the Turnitin plagiarism check is enabled.
Dependencies
This PR needs the new ORA submission view filter:
Supporting Information
These changes are based on those proposed in the following ADR
How to Test
Using Tutor:
Install this xblock with changes in this branch in the LMS/CMS services.
Install
openedx-filters
in the LMS/CMS services with these changes.Install
platform-plugin-turnitin
in the LMS/CMS services with the changes in the ora filter branch.Add the Open edX Filters configuration to your environment and restart the services. You can use this inline plugin:
In a unit of the course create a new ora assessment.
In the LMS, in the submission step (1. Your Response), you'll see: