build: remove unused libsass dependency #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdmccormick
force-pushed
the
kdmccormick/rm-libsass
branch
from
f5b6df0 to
ccb0ce8
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1987 +/- ##
=======================================
Coverage 94.99% 94.99%
=======================================
Files 155 155
Lines 17107 17107
Branches 1616 1616
=======================================
Hits 16250 16250
Misses 642 642
Partials 215 215
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
@openedx/content-aurora , per the release process I ran I tried Should I commit these changes, or leave them out? |
kdmccormick
changed the title
kdmccormick
force-pushed
the
kdmccormick/rm-libsass
branch
from
ccb0ce8 to
fae49ca
Compare
Bump version: 5.1.1 -> 5.2.0 TODO will paste in details from PR description Closes: openedx#1986
kdmccormick
force-pushed
the
kdmccormick/rm-libsass
branch
from
fae49ca to
8798579
Compare
e0d
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
This change looks completely reasonable to me, but I'm not in a good position to understand or test issues this might cause when it's deployed. As this is related to speeding up edx-platform deployment I wonder if ArchBOM could review? @jmbowman does that seem reasonable?
leangseu-edx
approved these changes
Jul 18, 2023
|
Thanks for the reviews! |
BryanttV
pushed a commit
to eduNEXT/edx-ora2
that referenced
this pull request
Feb 6, 2024
(Bumps version: 5.1.1 -> 5.2.0) We remove the libsass Python requirement as it doesn't seem to be used any more. (I was able to compile ORA's assets by running `make static`; no Python dependencies needed.) Removing libsass from ORA's requirements will allow us to move it out of edx-platform's base requirements and into a new static-asset-compilation-specific requirements stage. Libsass [1] is a deprecated Sass compilation library written in C, and installing it into edx-platform adds a whole minute to the build because there are no pre-compiled binaries available for the version we install. 1. https://sass-lang.com/libsass/ Closes: openedx#1986
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libsass Python requirement doesn't seem to be used any more. I was able to compile ORA's assets by running
make static; no Python dependencies needed.We are eager to remove libsass from ORA's base requirements because it'll allow us to optimize how edx-platform installs the library. Libsass is a deprecated Sass compilation library written in C, and installing it into edx-platform adds a whole minute to the build because there are no pre-compiled binaries available for the version we install.
Closes: #1986