Feat!: Upgrade to django42 #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UsamaSadiq
force-pushed
the
upgrade-to-django42
branch
2 times, most recently
from
b1f29af to
4d1d9b3
Compare
build: update CI
UsamaSadiq
force-pushed
the
upgrade-to-django42
branch
from
19af084 to
7aef431
Compare
UsamaSadiq
commented
Oct 9, 2023
| run: | | ||
| pip install -r requirements/travis.txt | ||
| docker exec -e TOXENV=${{ matrix.python-version }}-${{ matrix.django-version }} --env DB_HOST=${{ matrix.db-version }} -u root edx_notes_api \ |
There was a problem hiding this comment.
system packages needed to install mysqlclient==2.2.0. See release notes https://github.com/PyMySQL/mysqlclient#linux for details.
UsamaSadiq
commented
Oct 9, 2023
| # via pyjwt | ||
| django==3.2.20 | ||
| django==4.2.6 |
There was a problem hiding this comment.
Django version upgraded.
awais786
approved these changes
Oct 10, 2023
iamsobanjaved
added a commit
that referenced
this pull request
Oct 19, 2023
This reverts commit 2b5238a.
iamsobanjaved
added a commit
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TODO
Checklist for IDA before merging Django 4.2 upgrade PR
Verify Django is upgraded to 4.2 at all places
USE_DEPRECATED_PYTZ settings is added to base/common.py with an explanatory comment
memcached backend is changed from MemcachedCache to PyMemcacheCache in edx-internal (remote config/ argocd configs) - - - - No Cache Configured in edx-notes-api so this step is not needed.
CSRF_TRUSTED_ORIGINS are updated in configurations