Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added limited staff role #2185

Merged
merged 2 commits into from
Sep 18, 2023
Merged

docs: Added limited staff role #2185

merged 2 commits into from
Sep 18, 2023

Conversation

bpedx
Copy link
Contributor

@bpedx bpedx commented Sep 14, 2023

Add a description of your changes with links to any relevant material.

Date Needed (optional)

If the release date of a feature is known or estimated, provide it to give reviewers guidance on turnaround time.

Reviewers

Possible roles follow. The PR submitter checks the boxes after each reviewer finishes and gives 👍.

  • Subject matter expert:
  • Subject matter expert:
  • Product review:
  • Partner support:
  • PM review:

FYI: Tag anyone else who might be interested in this PR here.

Testing

  • Ran ./run_tests.sh without warnings or errors

HTML Version (optional)

  • Build an RTD draft for your branch and add a link here

Sandbox (optional)

  • Point to or build a sandbox for the software change and add a link here

Post-review

  • Add a comment with the description of this change or link this PR to the next release notes task.
  • Squash commits

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 14, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @bpedx! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

@mphilbrick211
Copy link

Hi @bpedx! Thanks for this contribution. Are you a 2U/edX employee? If so, you'll need to be added to their entity CLA (have your manager reach out to [email protected]. If you're contributing as an individual, you'll need to fill out the individual CLA as indicated above.

@bpedx
Copy link
Contributor Author

bpedx commented Sep 14, 2023 via email

@feanil
Copy link
Contributor

feanil commented Sep 15, 2023

FYI, I just updated Ben's records so the CLA bot should update overnight tonight.

@mphilbrick211
Copy link

FYI, I just updated Ben's records so the CLA bot should update overnight tonight.

Thanks, @feanil! FYI @bpedx

@feanil
Copy link
Contributor

feanil commented Sep 15, 2023

No, you are covered by the 2U Entity Agreement.

@bpedx
Copy link
Contributor Author

bpedx commented Sep 18, 2023

Nevermind, the checklist just updated itself... but now "this branch is out-of-date with the base branch". Should I Update Branch or should I Update with Rebase? @feanil

@mphilbrick211
Copy link

Hi @bpedx! Rebasing should fix it.

@feanil feanil enabled auto-merge September 18, 2023 16:51
@feanil feanil merged commit 5eed522 into openedx:master Sep 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants