Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added notification doc for course author and open edx student #2172

Closed
wants to merge 3 commits into from

Conversation

sundasnoreen12
Copy link
Contributor

INF-1017

Description
I added section Managing Notifications in both course_authors and open_edx_students

The content of this section is presented in this doc: https://docs.google.com/document/d/1xNtDBQWqiKe0H_iukkN7hr77Evljs3Zn4Fc-ZXBUM-g/edit - Connect your Google account

Testing

  • By running command make html in respective folder

Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update all heading styles to match the current documentation standard: https://docs.openedx.org/en/latest/documentors/references/quick_reference_rst.html#headings

@sundasnoreen12
Copy link
Contributor Author

Please update all heading styles to match the current documentation standard: https://docs.openedx.org/en/latest/documentors/references/quick_reference_rst.html#headings

Could you please provide an example of what the desired format should be? I'm seeking assistance from the reference document titled "en_us/open_edx_students/source/SFD_notes.rst".

instead of
########
Heading 1
########

should i use this
Heading 1
########

@awais-ansari awais-ansari enabled auto-merge (squash) September 4, 2023 08:13
@awais-ansari awais-ansari requested a review from feanil September 4, 2023 08:16
@sundasnoreen12
Copy link
Contributor Author

@feanil i created a duplicate PR because we need to merge the documentation related work created in this PR to enable product tour for notification on production. if I'm missing something, I'll fix that in this opened PR.

Duplicate PR link is here: #2176

@feanil
Copy link
Contributor

feanil commented Sep 5, 2023

It looks like you fixed the thing I requested in the duplicate PR so I think this is fine to close. Out of curiousity, how is this page being used in the product tour? Are you linking from the notifications code to these published pages in some way? Should there be comments here so that we can understand the impact of removing or renaming these pages in the future?

@awais-ansari
Copy link

It looks like you fixed the thing I requested in the duplicate PR so I think this is fine to close. Out of curiousity, how is this page being used in the product tour? Are you linking from the notifications code to these published pages in some way? Should there be comments here so that we can understand the impact of removing or renaming these pages in the future?

Screenshot 2023-09-05 at 4 18 15 PM

@awais-ansari
Copy link

Its a duplicate PR. #2176

@awais-ansari awais-ansari deleted the sundas/INF-1017 branch September 6, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants