Add support for python 3.12 #159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irtazaakram
force-pushed
the
pythonupgrade
branch
from
89506ad to
8114f7b
Compare
irtazaakram
changed the title
irtazaakram
force-pushed
the
pythonupgrade
branch
2 times, most recently
from
043a3e8 to
af71621
Compare
irtazaakram
force-pushed
the
pythonupgrade
branch
from
0a69d4c to
c5618c4
Compare
awais786
reviewed
Feb 20, 2024
| @@ -69,7 +69,8 @@ def get(self, request, course_id, *args, **kwargs): | |||
| filename = self.get_export_filename(course_id) | |||
|
|
|||
| response = StreamingHttpResponse(iterator, content_type='text/csv') | |||
| response['Content-Disposition'] = f'attachment; filename="{filename}"' | |||
| response_content = 'attachment;' | |||
There was a problem hiding this comment.
Any reference for this change ?
There was a problem hiding this comment.
This statement was raising pylint error Multiple statements on one line (semicolon) (E702)
|
Closing this as #160 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to openedx/axim-engineering#1045