fix: add namespace to path and route construction (external-secrets#3632

) * fix: add namespace to path and route construction Signed-off-by: Gergely Brautigam <[email protected]> * fix: use the correct namespace while restoring from auth namespace Signed-off-by: Gergely Brautigam <[email protected]> * added fix suggestion from Gustavo Signed-off-by: Gergely Brautigam <[email protected]> --------- Signed-off-by: Gergely Brautigam <[email protected]>
opendidx · Jul 21, 2024 · c078a88 · c078a88
1 parent 7f71b47
commit c078a88
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/pkg/provider/vault/auth.go b/pkg/provider/vault/auth.go
@@ -43,6 +43,10 @@ const (
 // setAuth gets a new token using the configured mechanism.
 // If there's already a valid token, does nothing.
 func (c *client) setAuth(ctx context.Context, cfg *vault.Config) error {
+	if c.store.Namespace != nil { // set namespace before checking the need for AuthNamespace
+		c.client.SetNamespace(*c.store.Namespace)
+	}
+
 	// Switch to auth namespace if different from the provider namespace
 	restoreNamespace := c.useAuthNamespace(ctx)
 	defer restoreNamespace()
@@ -200,7 +204,7 @@ func revokeTokenIfValid(ctx context.Context, client util.Client) error {
 
 func (c *client) useAuthNamespace(_ context.Context) func() {
 	ns := ""
-	if c.store.Namespace != nil {
+	if c.store != nil && c.store.Namespace != nil {
 		ns = *c.store.Namespace
 	}