Skip to content

Commit

Permalink
update the traffic test for ingress (kubernetes-sigs#3725)
Browse files Browse the repository at this point in the history
* update the traffic test for ingress

* make crds
  • Loading branch information
oliviassss authored May 30, 2024
1 parent f5dee3f commit 756fc5d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
1 change: 1 addition & 0 deletions config/webhook/manifests.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
apiVersion: admissionregistration.k8s.io/v1
kind: MutatingWebhookConfiguration
metadata:
Expand Down
13 changes: 9 additions & 4 deletions test/e2e/ingress/vanilla_ingress_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -766,10 +766,15 @@ var _ = Describe("vanilla ingress tests", func() {

// test traffic
ExpectLBDNSBeAvailable(ctx, tf, lbARN, lbDNS)
httpExp := httpexpect.New(tf.LoggerReporter, fmt.Sprintf("http://%v", lbDNS))
httpExp.GET("/path").Expect().
Status(http.StatusOK).
Body().Equal("Hello World!")

//TODO: update the traffic test for dualstack-without-public-ipv4 ALB
// as it may need additional setup compared to dualstack ALB
if annotation["alb.ingress.kubernetes.io/ip-address-type"] != "dualstack-without-public-ipv4" {
httpExp := httpexpect.New(tf.LoggerReporter, fmt.Sprintf("http://%v", lbDNS))
httpExp.GET("/path").Expect().
Status(http.StatusOK).
Body().Equal("Hello World!")
}
})
})
})
Expand Down

0 comments on commit 756fc5d

Please sign in to comment.