Add support for MariaDB #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
rnetser
requested changes
Oct 15, 2024
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
/verified |
rnetser
requested changes
Oct 22, 2024
| matching_pods = [pod for pod in pods if pod.labels.get(label_key) == label_value] | ||
| if not matching_pods: | ||
| return False | ||
| pod = matching_pods[0] |
There was a problem hiding this comment.
why do you check only the 1st pod?
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functions and fixtures to use MariaDB Operator
Description
TrustyAI allows users to bring their own database. For automated tests, we use MariaDB, through the use of MariaDB operator. This PR provides the necessary infra to use MariaDB in all the tests.
How Has This Been Tested?
Not tested yet, PR in draft state until tested
Merge criteria: