ci/cirrus: use vagrant from hashicorp repo, bump Fedora to 38, bump bats #3848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
reviewed
Apr 26, 2023
|
Ahh, the next problem is vagrant-libvirt plugin from ubuntu repo is not recognized by vagrant from the hashicorp repo (hashicorp/vagrant#12657). |
kolyshkin
force-pushed
the
bump-vagrant
branch
8 times, most recently
from
792b9a0 to
c9b6cf1
Compare
kolyshkin
changed the title
AkihiroSuda
reviewed
Apr 27, 2023
A version of vagrant available from the stock repos (2.2.19) is too old and contains a bug that prevents downloading Fedora 38 image (see [1]). Use packages from hashicorp repo, which currently has vagrant 2.3.4. This resolves the problem of downloading the latest Fedora image. Also, vagrant-libvirt plugin from Ubuntu repos is not working with vagrant from hashicorp, so switch to using "vagrant plugin install". The downside it, this takes extra 4 minutes or so in our CI, and I am not sure how to cache it or speed it up. [1] opencontainers#3835 (comment) Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
As Fedora 38 uses bats 1.9.0, let's switch to this version in other places. Signed-off-by: Kir Kolyshkin <[email protected]>
|
Filed a bug to Ubuntu: https://bugs.launchpad.net/vagrant/+bug/2017828 |
|
Do we want to backport it? I'm not entirely sure. @AkihiroSuda if you feel like it, just add a label. |
AkihiroSuda
approved these changes
Apr 27, 2023
AkihiroSuda
added
backport/1.1-pr
|
Backported to 1.1 in #3878. |
kolyshkin
added
backport/1.1-done
How can we get Ubuntu to look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Use vagrant from hashicorp repo.
A version of vagrant available from the stock repos (2.2.19) is too old and contains a bug that prevents downloading Fedora 38 image. The error looks like this:
Apparently, this is caused by hashicorp/vagrant#12921 (plus a combination of some server-side changes, I guess).
The code in question was added 5 years ago in vagrant 2.1.3 (hashicorp/vagrant@447e58d) , and it was fixed (by hashicorp/vagrant@c7ef689) in vagrant 2.3.1.
As Ubuntu 22.04 comes with vagrant 2.2.19, we hit the issue.
The solution is to use packages from hashicorp repo, which currently has vagrant 2.3.4.
This resolves the problem of downloading the latest Fedora image.
Also, vagrant-libvirt plugin from Ubuntu repos is not working with
vagrant from hashicorp, so switch to using "vagrant plugin install".
The downside it, this takes extra 4 minutes or so in our CI, and I
am not sure how to cache it or speed it up.
2. Bump Fedora to 38.
3. ci: bump bats 1.8.2 -> 1.9.0
As Fedora 38 uses bats 1.9.0, let's switch to this version in other
places.