Adds auto_restart to containerz.StopRequest. #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As there is no containerz.Restart() RPC it is possible to loose access to the device after calling Stop() on the contaier implementing the gNOI.containerz service. Adding the auto_restart field to the Stop() RPC solves this problem.
Pull Request Test Coverage Report for Build 6722832990
💛 - Coveralls |
marcushines
reviewed
Nov 1, 2023
containerz/containerz.proto
Outdated
|
|
||
| // If auto_restart is set, the target should start the container immediately | ||
| // after stopping it. | ||
| bool auto_restart = 3; |
There was a problem hiding this comment.
bool restart
i think auto_restart makes it feel like the container will always restart
There was a problem hiding this comment.
Make sense. Thx for making the change!
marcushines
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As there is no containerz.Restart() RPC it is possible to loose access to the device after calling Stop() on the container implementing the gNOI.containerz service.
Adding the auto_restart field to the Stop() RPC solves this problem.