Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LowerEqPattern and LowerDistinctPattern for pair types #55

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

Hatsunespica
Copy link
Collaborator

This PR includes 4 changes:

  1. LowerEqPattern
    For a pair eq comparison, we have
(= (pair lhsFirst lhsSecond) (pair rhsFirst rhsSecond))
->
(and (= lhsFirst rhsFirst) (= lhsSecond rhsSecond))
  1. LowerDistinctPattern
    For a pair distinct comparison, we have
(distinct (pair lhsFirst lhsSecond) (pair rhsFirst rhsSecond))
->
(or (distinct lhsFirst rhsFirst) (distinct lhsSecond rhsSecond))
  1. A test case for LowerEqPattern
  2. A test case for LowerDistinctPattern

@Hatsunespica Hatsunespica force-pushed the pair_eq branch 2 times, most recently from 94eecc9 to 4d9ba68 Compare December 18, 2024 04:23
Copy link
Contributor

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@math-fehr math-fehr merged commit f7afa07 into main Dec 18, 2024
2 checks passed
@math-fehr math-fehr deleted the pair_eq branch December 18, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants