Generic integer semantics #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
math-fehr
reviewed
Dec 15, 2024
Comment on lines
-10
to
+12
| // CHECK: %block_id1 = "smt.int.constant"() {"value" = 0 : i64} : () -> !smt.int.int | ||
| // CHECK-NEXT: %block_id2 = "smt.int.constant"() {"value" = 1 : i64} : () -> !smt.int.int | ||
| // CHECK-NEXT: %block_id3 = "smt.int.constant"() {"value" = 2 : i64} : () -> !smt.int.int | ||
| // CHECK: %block_id1 = "smt.int.constant"() {"value" = 0 : ui128} : () -> !smt.int.int | ||
| // CHECK-NEXT: %block_id2 = "smt.int.constant"() {"value" = 1 : ui128} : () -> !smt.int.int | ||
| // CHECK-NEXT: %block_id3 = "smt.int.constant"() {"value" = 2 : ui128} : () -> !smt.int.int |
There was a problem hiding this comment.
I'll fix this in another PR, but actually we have the IntAttr attribute that can represent arbitrary bitwidth integers, it's probably better suited here.
Comment on lines
473
to
495
| def are_generic_integers_defined_on( | ||
| module_op: Operation, | ||
| ): | ||
| forbidden_ops = [arith.OrI.name, arith.XOrI.name, arith.ShLI.name, arith.DivSI.name] | ||
| forbidden_ops += [o.name for o in comb.Comb.operations] | ||
| use_parametric_int = True | ||
| for inner_op in module_op.walk(): | ||
| if isinstance(inner_op, pdl.OperationOp): | ||
| op_name = str(inner_op.opName).replace('"', "") | ||
| if op_name in forbidden_ops: | ||
| use_parametric_int = False | ||
| break | ||
| if isinstance(inner_op, pdl.ApplyNativeConstraintOp): | ||
| constraint_name = str(inner_op.constraint_name).replace('"', "") | ||
| if constraint_name == "is_minus_one": | ||
| use_parametric_int = False | ||
| break | ||
| if isinstance(inner_op, pdl.ApplyNativeRewriteOp): | ||
| constraint_name = str(inner_op.constraint_name).replace('"', "") | ||
| if constraint_name == "get_width": | ||
| use_parametric_int = False | ||
| break | ||
| return use_parametric_int |
There was a problem hiding this comment.
What does this function do? I'm not sure I understand
There was a problem hiding this comment.
I add a doc comment. Returns False if there is an operation in module_op that is not supported by generic integer semantics. Returns True otherwise. I use it later in pdl_to_smt to decide wether I should load the generic integer semantics or the fixed one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic integer semantics sound enough to be the foundation of PDL to SMT passes.