Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UKV channel permutation #95

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Fix UKV channel permutation #95

merged 2 commits into from
Jul 1, 2024

Conversation

dfulu
Copy link
Member

@dfulu dfulu commented Jul 1, 2024

An issue occurred in creating the v9 batches where the UKV channels were rearranged into alphabetical order. This meant when training the model was given the UKV channels in alphabetical order but live we were feeding them in in the order they appeared in the data config.

This pull request updates all the models using UKV so the data config used live has the UKV channels in alphabetical order and thus aligns train and production

Also added back in some of the models with different levels of satellite delay

@dfulu dfulu requested a review from peterdudfield July 1, 2024 09:48
Copy link
Contributor

@peterdudfield peterdudfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once tests are fixed

@peterdudfield
Copy link
Contributor

I think this is linked with this - openclimatefix/ocf_datapipes#326

@dfulu dfulu merged commit e6035c4 into main Jul 1, 2024
2 checks passed
@dfulu dfulu deleted the ukv_channel_permute branch July 1, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants