Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll back datapipes to before major changes #9

Closed
wants to merge 2 commits into from
Closed

Conversation

dfulu
Copy link
Member

@dfulu dfulu commented Sep 19, 2023

Pull Request

Description

Model has been behaving strangely since most recent build. Roll back ocf_datapipes to before major changes in that repo. At least this will rule-out whether the decreased model performance comes from that.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #9 (4322866) into main (9608d16) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage   92.89%   92.89%           
=======================================
  Files           2        2           
  Lines         197      197           
=======================================
  Hits          183      183           
  Misses         14       14           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dfulu dfulu closed this Sep 19, 2023
@dfulu dfulu deleted the rollback branch September 19, 2023 12:42
@dfulu
Copy link
Member Author

dfulu commented Sep 19, 2023

Realised that the previous build was using ocf_datapipes v1.2.44 anyway due to requirements stemming from the pvnet repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant