Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ecmwf #48

Merged
merged 5 commits into from
Mar 4, 2024
Merged

Add ecmwf #48

merged 5 commits into from
Mar 4, 2024

Conversation

dfulu
Copy link
Member

@dfulu dfulu commented Feb 29, 2024

Pull Request

Description

Add support for PVNet to use ECMWF NWP data as well as UKV

This replaces the default PVNet model with one which uses the ECMWF data. It leaves the summation model the same though this should be retrained before going into production.

The following environmental variables now need to be set

  • NWP_UKV_ZARR_PATH which replaces NWP_ZARR_PATH
  • NWP_ECMWF_ZARR_PATH

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@dfulu dfulu requested a review from peterdudfield February 29, 2024 18:07
@dfulu dfulu merged commit 7cdc79d into main Mar 4, 2024
2 checks passed
@dfulu dfulu deleted the add_ecmwf branch March 4, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants