Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/no 5 min data #42

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Issue/no 5 min data #42

merged 4 commits into from
Feb 8, 2024

Conversation

peterdudfield
Copy link
Contributor

Pull Request

Description

  • dont cause bug if there is no 5 minute satellite data

Fixes #41

How Has This Been Tested?

Add tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield requested a review from dfulu February 8, 2024 09:33
dfulu
dfulu approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@dfulu dfulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for the fix

@peterdudfield peterdudfield merged commit bd47d14 into main Feb 8, 2024
2 checks passed
@peterdudfield peterdudfield deleted the issue/no-5-min-data branch February 8, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfulu dfulu dfulu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no 5 minute sat data file
2 participants
@peterdudfield @dfulu