Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add properties only when not empty #27

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Add properties only when not empty #27

merged 1 commit into from
Nov 13, 2023

Conversation

dfulu
Copy link
Member

@dfulu dfulu commented Nov 13, 2023 •
edited
Loading

Pull Request

Description

Add properties to the forecast only when they are not null. Stops us uploading an empty dict. This is mainly for pvnet_sum_gsps.

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@dfulu dfulu marked this pull request as ready for review November 13, 2023 17:17
@dfulu dfulu merged commit a4efeae into main Nov 13, 2023
2 checks passed
@dfulu dfulu deleted the pvnet_gsp_sum_properties branch November 13, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dfulu