Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/re grid #26

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Bug/re grid #26

merged 4 commits into from
Nov 6, 2023

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Nov 6, 2023 •
edited
Loading

Pull Request

Description

Tidy up docker file

This might help with #25

How Has This Been Tested?

  • CI tests

  • run docker file locally, and dont get warning. TODO run docker file completely

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield self-assigned this Nov 6, 2023
@peterdudfield peterdudfield requested a review from dfulu November 6, 2023 21:35
@peterdudfield peterdudfield merged commit af3894c into main Nov 6, 2023
2 checks passed
@peterdudfield peterdudfield deleted the bug/re-grid branch November 6, 2023 22:09
@peterdudfield
Copy link
Contributor Author

decided to push this through, but happy with any comments tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfulu dfulu Awaiting requested review from dfulu

Assignees

@peterdudfield peterdudfield

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@peterdudfield