Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hugface dataconf #20

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Hugface dataconf #20

merged 4 commits into from
Nov 2, 2023

Conversation

dfulu
Copy link
Member

@dfulu dfulu commented Oct 31, 2023

Pull Request

Description

These changes allow us to load the data config from huggingface rather than having it in this repo. Along with recent changes in PVNet openclimatefix/PVNet#89 this means we can better version control the PVNet model and its data config

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #20 (8645e93) into main (6d3b4e5) will increase coverage by 0.95%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   93.23%   94.19%   +0.95%     
==========================================
  Files           2        2              
  Lines         207      224      +17     
==========================================
+ Hits          193      211      +18     
+ Misses         14       13       -1     
Files Coverage Δ
pvnet_app/app.py 94.17% <100.00%> (+0.96%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dfulu dfulu requested a review from peterdudfield October 31, 2023 21:12
Copy link
Contributor

@peterdudfield peterdudfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, then the configuration is linked to the hf model

@dfulu dfulu merged commit 025aa6e into main Nov 2, 2023
5 checks passed
@dfulu dfulu deleted the hugface_dataconf branch November 2, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants