Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No satellite nans #159

Merged
merged 5 commits into from
Dec 17, 2024
Merged

No satellite nans #159

merged 5 commits into from
Dec 17, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Dec 17, 2024 •
edited
Loading

Pull Request

Description

  • Raise error if there are any nans in the satellite data
  • This reuses some code, for checking for zeros

#158

How Has This Been Tested?

Ci tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield requested a review from dfulu December 17, 2024 13:44
dfulu
dfulu approved these changes Dec 17, 2024
View reviewed changes
pvnet_app/data/satellite.py Show resolved Hide resolved
pvnet_app/consts.py Show resolved Hide resolved
@peterdudfield peterdudfield merged commit f22d779 into main Dec 17, 2024
2 checks passed
@peterdudfield peterdudfield deleted the no-satellite-nans branch December 17, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfulu dfulu dfulu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdudfield @dfulu