Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update summation model to reduce wobbles #12

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Update summation model to reduce wobbles #12

merged 1 commit into from
Sep 22, 2023

Conversation

dfulu
Copy link
Member

@dfulu dfulu commented Sep 21, 2023

Pull Request

Description

This updates the summation model used.

The current summation model is a bit noisy. In our forecasts there are some high frequency perturbations from a smooth curve which I do not believe are indicative of model skill, but more the model being overly sensitive to the inputs. Although the accuracy of the model is good, I think it makes us look bad from a user's perspective - can we trust an accurate but wobbly line? These high frequency deviations would also likely make our forecasts worse as measured by ramp-rate.

This new model is trained with more effective regularisation (due to rescaling the inputs), and is trained for longer using a slower changing learning rate. This results in smoother forecasts, and a very modest improvement in validation scores.

Both the new and old model were trained and validated on the exact same batches, so their validation results can be directly compared. Validation results, and the wandb training logs for the two models are shown below.

model Validation NMAE Validation Quantile Loss wandb training log
old 0.01448 0.009512 https://wandb.ai/openclimatefix/pvnet_summation/runs/zda9wo7u
new 0.01431 0.009384 https://wandb.ai/openclimatefix/pvnet_summation/runs/xuvy4ld8

@dfulu
Copy link
Member Author

dfulu commented Sep 21, 2023

Example validation results from old model - slightly wobbly predictions
media_images_val_forecast_samples_batch_idx_0_265_dd04c9f0a3afe9648587

@dfulu
Copy link
Member Author

dfulu commented Sep 21, 2023

Same example validation results from new model - predicts smoother curves
media_images_val_forecast_samples_batch_idx_0_1279_e9a847919f8e0f8fe829

@dfulu dfulu requested a review from peterdudfield September 21, 2023 13:02
@dfulu dfulu changed the title Update summation model Update summation model to reduce wobbles Sep 21, 2023
@dfulu
Copy link
Member Author

dfulu commented Sep 21, 2023

Note these tests aren't passing due to the temporary bug fix we put in to compensate for the nwp-consumer bug

@dfulu dfulu added the enhancement New feature or request label Sep 21, 2023
Copy link
Contributor

@peterdudfield peterdudfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can we make sure these results are added to the PVnet doc.
Or perhaps there is a seperate doc the the PVnet summation model - again I would push for markdown files as he is an example of a short experiment that produce a postive results, but if you done it in the google doc thats also ok

@dfulu
Copy link
Member Author

dfulu commented Sep 22, 2023

I'll add it to the PVNet doc. I think its really hard to maintain set of markdowns. I have had to edit the PVNet doc a bunch to recontextualise previous experiment write-ups, to update them, or to remove them as we've progressed. And that seems pretty clunky to do with a series of markdowns

@dfulu dfulu merged commit 6354dd5 into main Sep 22, 2023
1 of 3 checks passed
@peterdudfield peterdudfield deleted the new_model branch September 25, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants