Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocf data sampler #118

Merged
merged 17 commits into from
Sep 16, 2024
Merged

Ocf data sampler #118

merged 17 commits into from
Sep 16, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Aug 16, 2024

Pull Request

Description

  • Upgrade to ocf_data_sampler
  • keep old ocf_datapipes for legacy
  • added new PVNET models
  • Keep old PVNET DA model

Helps - openclimatefix/ocf-data-sampler#7

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield marked this pull request as draft August 16, 2024 13:02
@dfulu
Copy link
Member

dfulu commented Sep 16, 2024

@peterdudfield I've added the newly trained models to this and took out the fake GSP data since the new ocf-data-sampler doesn't require it anymore

@dfulu dfulu marked this pull request as ready for review September 16, 2024 12:39
pvnet_app/app.py Outdated Show resolved Hide resolved
tests/test_app.py Outdated Show resolved Hide resolved
pvnet_app/app.py Outdated Show resolved Hide resolved
pvnet_app/app.py Outdated Show resolved Hide resolved
@peterdudfield peterdudfield merged commit 175615f into main Sep 16, 2024
2 checks passed
@peterdudfield peterdudfield deleted the ocf-data-sampler branch September 16, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants