Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

temp bug fix #10

Merged
merged 1 commit into from
Sep 19, 2023
Merged

temp bug fix #10

merged 1 commit into from
Sep 19, 2023

Conversation

dfulu
Copy link
Member

@dfulu dfulu commented Sep 19, 2023 •
edited
Loading

Pull Request

Description

A bug fix to compensate for the y-axis inversion in the nwp-consumer. 2 bugs = no bugs

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

peterdudfield
peterdudfield reviewed Sep 19, 2023
View reviewed changes
pvnet_app/app.py
########
# TO DO: THIS IS A TEMPORARY BUG FIX TO COMPENSATE FOR A BUG IN THE NWP CONSUMER FLIPPING THE
# Y-AXIS IN THE NWP
ds = xr.open_zarr("nwp.zarr").compute()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add logger.warning

@dfulu dfulu merged commit 54c725c into main Sep 19, 2023
1 of 3 checks passed
@dfulu dfulu mentioned this pull request Sep 25, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterdudfield peterdudfield peterdudfield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfulu @peterdudfield