Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elexon forecast route #350

Merged
merged 15 commits into from
Aug 13, 2024
Merged

Add elexon forecast route #350

merged 15 commits into from
Aug 13, 2024

Conversation

peterdudfield
Copy link
Collaborator

@peterdudfield peterdudfield commented Jul 31, 2024

Pull Request

Description

  • remove try and except in national
  • update test, to mock results

minor updates to ci workflow

How Has This Been Tested?

Ci tests + new test

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

14Richa and others added 4 commits July 31, 2024 14:14
…rom elexonpy package (#347)

* added import statements of elexonpy

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* added API for solar forecast

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* minor fix

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* minor fix

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* changed function name

* added filter functionality

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* added API link

* minor fix

* remove try except block

* changed bmrs to elexon

* minor fix

* resolving pre hook

* minor fix in docstring

* removed router

* minor fix in naming

* added elexonpy in requirement.txt file

* resolve hook error

* minor fix

* added response model

* fixed unit test

* remove plevel

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@peterdudfield peterdudfield requested a review from braddf July 31, 2024 14:34
@peterdudfield
Copy link
Collaborator Author

@14Richa ive updated the test here

src/national.py Outdated Show resolved Hide resolved
@peterdudfield peterdudfield changed the title Development Add elexon forecast route Jul 31, 2024
Copy link
Contributor

@braddf braddf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, couple of comments to clarify things but otherwise LGTM

src/national.py Outdated Show resolved Hide resolved
src/tests/test_elexon_forecast.py Outdated Show resolved Hide resolved
src/tests/test_elexon_forecast.py Outdated Show resolved Hide resolved
@peterdudfield peterdudfield merged commit 2f98d4f into main Aug 13, 2024
2 checks passed
@peterdudfield peterdudfield deleted the development branch August 13, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants