run alembic migrations instead of using sqlalchemy to migrate test db #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mduffin95
changed the title
|
Not sure why the github actions workflow isn't running |
The CI is currently set up only to run when a PR is opened. I need (or you could if you fancy it) change this so it runs on every change |
|
@peterdudfield I've fixed this PR and also added #171 to add the |
peterdudfield
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
As long as the tests pass, I'm happy with this.
Thanks @mduffin95 for doing this, let me know if this is ready
|
@peterdudfield yep it's ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial change required for work on #165.
Currently the tests do not seem to test the actual alembic migrations but instead use sqlalchemy directly to build the DB schema. I guess this is problematic because it's not really testing what's in prod.
Because as part of #165 I'd like to use a DB trigger it makes sense to instead apply the alembic migrations so that it can be tested. The existing test setup wouldn't add the trigger.