Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/160 2 user #162

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Issue/160 2 user #162

merged 3 commits into from
Oct 1, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Oct 1, 2024 •
edited
Loading

Pull Request

Description

  • on conflict do nothing for adding a new user
  • TDD, to check it works

This fixes the problem that the UI calls the API with two requests at the same time, the API tries to make to users at the same time, and we get a conflict

Fixes #160

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield requested a review from devsjc October 1, 2024 08:25
@peterdudfield peterdudfield merged commit ceaec24 into main Oct 1, 2024
4 checks passed
@peterdudfield peterdudfield deleted the issue/160-2-user branch October 1, 2024 08:36
@peterdudfield peterdudfield mentioned this pull request Oct 1, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsjc devsjc devsjc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

try and except around making a new user
2 participants
@peterdudfield @devsjc