Add client table #158
Merged
Add client table #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add clientSQL in splmodels, with client_name Mapped relationships between Client and Site
added create_client and edit_client functions, and related tests. edited PVSiteEditMetadata pydantic model, so edit_site function can update the client_uuid. edited create_site function, so it can set the client_uuid.
Moved the client functions from user_and_site.py to client.py
Added get_client_by_name function, and related tests. This function can create a new client if it doesn't exist.
|
Hi @Bvr4 Thanks so much for this. You ok to adjust the alembic migration, its just becasue another one has sneaked in this before this. You can either update the hash in the migrations, or just re make it. I think other than, that, its ready to go |
|
OK, I'll take a look at it next week. |
Thanks @Bvr4 |
|
I edited the revises and down_revision hashes in the alembic migration. I guess it will do the trick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR refers to the issue #148 Client table.
Added client table with client_name. Mapped the table with sites.
Made alembic migration.
Added read functions : get_sites_by_blient_name and get_client_by_name (with the option of creating the client if it doesn't exist.
Added write functions : create_client, edit_client, assign_site_to_client.
Fixes #
How Has This Been Tested?
I created the tests associated with each function, via pytest.
For that, I made small modifications to conftest.py, like the creation of a client fixture.
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: