Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ml id column sites #155

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Update ml id column sites #155

merged 5 commits into from
Sep 20, 2024

Conversation

Sukh-P
Copy link
Member

@Sukh-P Sukh-P commented Sep 19, 2024

Pull Request

Description

This change drops the uniqueness requirement for the ml_id column in the sites table. The create site function has been modified slightly to include ml_id as an input so this can be easily tested.

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@Sukh-P Sukh-P marked this pull request as ready for review September 19, 2024 11:59
@Sukh-P
Copy link
Member Author

Sukh-P commented Sep 19, 2024

@peterdudfield I have had a go at the change we talked about regarding the ml_id column in the site table, first time touching this repo so feel free to point out bits that may need changing or anything else

Copy link
Contributor

@peterdudfield peterdudfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start, one small point ive added.

Would you be able to run a alembic migration? Ill happily do this together with you, if you like

@Sukh-P Sukh-P merged commit 9a09bbc into main Sep 20, 2024
2 checks passed
@Sukh-P Sukh-P deleted the update-ml-id-column-sites branch September 20, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants