Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/log memory usage #175

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

BraunRudolf
Copy link
Contributor

Pull Request

Description

Solving: Issue: log memory usage #171

add memory logging in pv_stie_api.cache.remove_old_cache

  • logging of memory after removing old cache entries

add requirement psutil

add tests/test_cache.py

  • testing entry removal
  • testing correct logging messages

new requirement: psutil

Fixes #171

How Has This Been Tested?

Unit-Test

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

add memory logging in pv_stie_api.cache.remove_old_cache
- logging of memory after removing old cache entries
add requirement psutil
add tests/test_cache.py
- testing entry removal
- testing correct logging messages

Signed-off-by: Rudolf Braun <[email protected]>
Signed-off-by: Rudolf Braun <[email protected]>
Signed-off-by: Rudolf Braun <[email protected]>
Copy link

sentry-io bot commented Jun 21, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: pv_site_api/cache.py

Function Unhandled Issue
remove_old_cache RuntimeError: dictionary changed size during iteration /sites/pv_...
Event Count: 1
remove_old_cache RuntimeError: dictionary changed size during iteration /sites/{site_uuid}/pv_fo...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@peterdudfield
Copy link
Contributor

Thank you @BraunRudolf

@peterdudfield peterdudfield merged commit 560a566 into openclimatefix:main Jun 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log memory usage
2 participants