Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change client_site_id to int #140

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Jan 23, 2024

Pull Request

Description

Change client_site_id to int

Fixes #139

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link
Contributor

@zakwatts zakwatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@peterdudfield peterdudfield merged commit 98b72e2 into main Jan 23, 2024
4 checks passed
@peterdudfield peterdudfield deleted the issue/139-client-site-id branch January 23, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

client_site_id should be interger
2 participants