Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrades to create site #137

Merged
merged 10 commits into from
Jan 23, 2024
Merged

Upgrades to create site #137

merged 10 commits into from
Jan 23, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Jan 23, 2024 •
edited
Loading

  1. use create_site from datamodel
  2. save site for user site doesnt get add to site group #123
  3. auto get dno and gsp Add DNO when adding a site #108

Pull Request

  1. use create_site from datamodel
  2. save site for user site doesnt get add to site group #123
  3. auto get dno and gsp Add DNO when adding a site #108

How Has This Been Tested?

  • CI tests

  • ran locally

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield
1. use create_site from datamodel
c9a1d1f 
2. save site for user #123
3. auto get dno and gsp #108
@zakwatts zakwatts changed the title Upgrades to creat site Upgrades to create site Jan 23, 2024
zakwatts
zakwatts reviewed Jan 23, 2024
View reviewed changes
pv_site_api/main.py Outdated Show resolved Hide resolved
zakwatts
zakwatts approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@zakwatts zakwatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@peterdudfield peterdudfield merged commit 4650cb4 into main Jan 23, 2024
2 checks passed
@peterdudfield peterdudfield deleted the issue/add-site branch January 23, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakwatts zakwatts zakwatts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdudfield @zakwatts