Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add links for swagger UI and docs to API docs #130

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

rachel-labri-tipton
Copy link
Contributor

@rachel-labri-tipton rachel-labri-tipton commented Nov 27, 2023

Pull Request

Description

Adds a brief description to the PV Site API docs that will better communicate to users how to test out the API. The links I've added should just add /docs or /swagger to the page's base url.

Screenshot 2023-11-27 at 12 55 31

Fixes # issue that came up in the Full Stack Chat this morning

How Has This Been Tested?

Ran the api locally to view the changes.

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield
Copy link
Contributor

peterdudfield commented Nov 27, 2023

Is it worth doing swagger hyperlink? I understand then the dev site would connect to production though

@rachel-labri-tipton
Copy link
Contributor Author

yeah, dev would connect to production. but that might be the best way to point users to correct url.

@peterdudfield
Copy link
Contributor

yeah, dev would connect to production. but that might be the best way to point users to correct url.

Yea, do you mind doing that?

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72eacd9) 95.20% compared to head (1980020) 95.20%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #130   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files          11       11           
  Lines         625      625           
=======================================
  Hits          595      595           
  Misses         30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rachel-labri-tipton rachel-labri-tipton merged commit ef329a3 into main Nov 27, 2023
4 checks passed
@peterdudfield peterdudfield deleted the issue/add-swagger-information-to-docs branch December 8, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants