Basic Evaluation #23
Merged
Basic Evaluation #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update 2021-11-20 in testset
Closed
zakwatts
reviewed
Dec 19, 2023
zakwatts
reviewed
Dec 19, 2023
| | 0 | 0.202 +- 0.03 | 6.2 | | ||
| | 1 | 0.211 +- 0.03 | 6.4 | | ||
| | 2 | 0.216 +- 0.03 | 6.5 | | ||
| | 3 - 4 | 0.211 +- 0.02 |6.3 | |
There was a problem hiding this comment.
It's very odd the 0th hour horizon is the same as the 24-48 hour horizon.
There was a problem hiding this comment.
Yea it is a bit. I suspect this might be due to the model being trained expecting live pv data.
There was a problem hiding this comment.
Ive added this to the Readme.md under the evaluation
There was a problem hiding this comment.
Okay, that could explain it. Is the current model trained without any pv_dropout at all?
zakwatts
reviewed
Dec 19, 2023
|
|
||
| site = PVSite( | ||
| latitude=pv_row["latitude"], | ||
| longitude=pv_row["longitude"], |
There was a problem hiding this comment.
Good next task, that i could do could be add in the tilt and orientation code
There was a problem hiding this comment.
Yea I agree, we have to do that for the trained model, right?
zakwatts
reviewed
Dec 19, 2023
zakwatts
reviewed
Dec 19, 2023
zakwatts
reviewed
Dec 19, 2023
zakwatts
reviewed
Dec 19, 2023
zakwatts
reviewed
Dec 19, 2023
peterdudfield
commented
Dec 19, 2023
zakwatts
approved these changes
Dec 19, 2023
zakwatts
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Add evaluations model which pull data from
Fixes #2
How Has This Been Tested?
Added tests + ran on a small tests set
Checklist: