Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to use linear interpolation to fill gaps in input data #230

Merged
merged 9 commits into from
Oct 23, 2023

Conversation

dfulu
Copy link
Member

@dfulu dfulu commented Oct 23, 2023

Pull Request

  • This adds functionality to SelectTimeSliceIterDataPipe to allow linear interpolation infilling of missing values up to a maximum number of consecutive time steps.
  • Tests added for this functionality
  • Added to pvnet production datapipe

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@dfulu dfulu requested a review from jacobbieker October 23, 2023 14:16
Copy link
Member

@jacobbieker jacobbieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job!

ocf_datapipes/select/select_time_slice.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #230 (c7d8da3) into main (dbd6e8d) will increase coverage by 0.21%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
+ Coverage   79.73%   79.94%   +0.21%     
==========================================
  Files         126      126              
  Lines        5507     5551      +44     
==========================================
+ Hits         4391     4438      +47     
+ Misses       1116     1113       -3     
Files Coverage Δ
ocf_datapipes/select/select_time_slice.py 100.00% <100.00%> (ø)
ocf_datapipes/training/pvnet.py 82.02% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dfulu dfulu merged commit 5003963 into main Oct 23, 2023
4 checks passed
@dfulu dfulu deleted the sat_fill_gaps branch October 23, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants