Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PVNet datapipe to support ECMWF #229

Merged
merged 13 commits into from
Oct 26, 2023
Merged

Update PVNet datapipe to support ECMWF #229

merged 13 commits into from
Oct 26, 2023

Conversation

jacobbieker
Copy link
Member

@jacobbieker jacobbieker commented Oct 23, 2023

Pull Request

Description

This adds support for loading different providers of NWP data in the common datapipe utility, focused primarily on PVNet forecasting.

Fixes #

How Has This Been Tested?

Unit tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@jacobbieker jacobbieker added the enhancement New feature or request label Oct 23, 2023
@jacobbieker jacobbieker self-assigned this Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #229 (39d7bbb) into main (2c39650) will increase coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is 77.77%.

❗ Current head 39d7bbb differs from pull request most recent head d17bdc7. Consider uploading reports for the commit d17bdc7 to get more accurate results

@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
+ Coverage   80.11%   80.13%   +0.02%     
==========================================
  Files         127      127              
  Lines        5611     5614       +3     
==========================================
+ Hits         4495     4499       +4     
+ Misses       1116     1115       -1     
Files Coverage Δ
ocf_datapipes/training/common.py 98.08% <ø> (ø)
ocf_datapipes/training/example/nwp_pv.py 89.28% <100.00%> (ø)
ocf_datapipes/load/nwp/nwp.py 92.85% <71.42%> (-4.58%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jacobbieker jacobbieker requested a review from dfulu October 24, 2023 12:23
@jacobbieker jacobbieker marked this pull request as ready for review October 24, 2023 12:23
if (
configuration.input_data.nwp.nwp_provider == "UKMetOffice"
or configuration.input_data.nwp.nwp_provider == "ukv"
):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could make this slightly tidier using:
if configuration.input_data.nwp.nwp_provider in [ "UKMetOffice", "ukv"]?

@jacobbieker jacobbieker merged commit 3cdbfe9 into main Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants