-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PVNet datapipe to support ECMWF #229
Conversation
Codecov Report
@@ Coverage Diff @@
## main #229 +/- ##
==========================================
+ Coverage 80.11% 80.13% +0.02%
==========================================
Files 127 127
Lines 5611 5614 +3
==========================================
+ Hits 4495 4499 +4
+ Misses 1116 1115 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
if ( | ||
configuration.input_data.nwp.nwp_provider == "UKMetOffice" | ||
or configuration.input_data.nwp.nwp_provider == "ukv" | ||
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could make this slightly tidier using:
if configuration.input_data.nwp.nwp_provider in [ "UKMetOffice", "ukv"]
?
Pull Request
Description
This adds support for loading different providers of NWP data in the common datapipe utility, focused primarily on PVNet forecasting.
Fixes #
How Has This Been Tested?
Unit tests
Checklist: