Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 site database #683

Merged
merged 7 commits into from
Nov 14, 2024
Merged

S3 site database #683

merged 7 commits into from
Nov 14, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Nov 11, 2024 •
edited
Loading

Pull Request

Description

  • Change database clean up to ecs_task
  • add SAVE_DIR to database clean up (using s3 bucket that current the forecast ml models are saved in)

#674

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield marked this pull request as ready for review November 13, 2024 20:08
@peterdudfield peterdudfield requested a review from devsjc November 14, 2024 09:40
devsjc
devsjc approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@devsjc devsjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@peterdudfield peterdudfield merged commit 6fef852 into main Nov 14, 2024
5 checks passed
@peterdudfield peterdudfield deleted the s3-site-database branch November 14, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsjc devsjc devsjc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdudfield @devsjc