Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copy files over ocf_datapipes #57

Merged
merged 9 commits into from
Oct 1, 2024
Merged

copy files over ocf_datapipes #57

merged 9 commits into from
Oct 1, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Sep 27, 2024 •
edited
Loading

Pull Request

Description

  • Move over location, geospatial files
  • tried to trim out as much as possible

Helps with #58

How Has This Been Tested?

CI test

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@codecov Codecov
Copy link

codecov bot commented Sep 27, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@AUdaltsova
Copy link
Contributor

AUdaltsova commented Sep 30, 2024 •
edited
Loading

very much outside the scope of this pr and also I might be misreading this, but I think we never actually use spatial padding? The option for it defaults to false and cannot be controlled from the config I don't think... gonna go make an issue about this

UPD: #62

dfulu
dfulu requested changes Sep 30, 2024
View reviewed changes
Copy link
Member

@dfulu dfulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of small things I think we should clean up, but otherwise looks good!

ocf_data_sampler/select/geospatial.py Outdated Show resolved Hide resolved
ocf_data_sampler/select/geospatial.py Outdated Show resolved Hide resolved
@peterdudfield
Copy link
Contributor Author

very much outside the scope of this pr and also I might be misreading this, but I think we never actually use spatial padding? The option for it defaults to false and cannot be controlled from the config I don't think... gonna go make an issue about this

UPD: #62

THanks @AUdaltsova and good to get this in another issue.

@dfulu let me know if your happy for me to merge

dfulu
dfulu approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@dfulu dfulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for doing this

ocf_data_sampler/select/geospatial.py Outdated
_lon_lat_to_osgb = pyproj.Transformer.from_crs(
crs_from=WGS84, crs_to=OSGB36, always_xy=True
).transform
_geod = pyproj.Geod(ellps="WGS84")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is used anywhere. If so can we strip it out?

@peterdudfield peterdudfield merged commit a708e9f into main Oct 1, 2024
3 checks passed
@peterdudfield peterdudfield deleted the issue/location branch October 1, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AUdaltsova AUdaltsova AUdaltsova approved these changes

@dfulu dfulu dfulu approved these changes

@Sukh-P Sukh-P Awaiting requested review from Sukh-P

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterdudfield @AUdaltsova @dfulu