feat(gfs): Add test against file with nothing in

openclimatefix · Nov 26, 2024 · 84b72a0 · 84b72a0
1 parent 2632082
commit 84b72a0
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/src/nwp_consumer/internal/repositories/model_repositories/noaa_s3.py b/src/nwp_consumer/internal/repositories/model_repositories/noaa_s3.py
@@ -283,6 +283,13 @@ def _convert(path: pathlib.Path) -> ResultE[list[xr.DataArray]]:
                 ],
             )
 
+        if len(processed_das) == 0:
+            return Failure(ValueError(
+                f"The file at '{path}' does not contain any variables of interest. "
+                "Ensure the conversion pipeline is not accidentally dropping wanted variables, ",
+                "and that the file contains variables of interest.",
+            ))
+
         return Success(processed_das)
 
     @staticmethod

diff --git a/src/nwp_consumer/internal/repositories/model_repositories/test_HRES-GFS_aptmp.grib b/src/nwp_consumer/internal/repositories/model_repositories/test_HRES-GFS_aptmp.grib
diff --git a/src/nwp_consumer/internal/repositories/model_repositories/test_noaa_s3.py b/src/nwp_consumer/internal/repositories/model_repositories/test_noaa_s3.py
@@ -132,6 +132,10 @@ class TestCase:
                 filename="test_HRES-GFS_r.grib",
                 should_error=False,
             ),
+            TestCase(
+                filename="test_HRES-GFS_aptmp.grib",
+                should_error=True,
+            ),
             TestCase(
                 filename="test_UM-Global_t2m.grib",
                 should_error=True,